Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: update fedora base images to fedora 39 #161

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

With the recent release of samba-container and the somewhat recent release of Fedora 39, now is a good time to update the fedora version we are tracking.

With the recent release of samba-container and the somewhat recent
release of Fedora 39, now is a good time to update the fedora version we
are tracking.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @phlogistonjohn, I suggest we remove the Draft status and can get this merged quickly.

@phlogistonjohn phlogistonjohn marked this pull request as ready for review November 29, 2023 12:37
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Please note: running git grep -n fedora:38 shows that we still have docs/development.md:79:FROM registry.fedoraproject.org/fedora:38 -- consider fix in this PR.

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@obnoxxx obnoxxx merged commit 1e99a87 into samba-in-kubernetes:master Nov 29, 2023
30 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-fc39 branch November 29, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants