mount: use 'random.randbytes' in _generate_random_bytes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shwetha-Acharya
approved these changes
Sep 20, 2023
|
From what I understand, PR #27 will need to be re-based to use this new code. Is this correct? |
Yes, but I just realized the CI is still using CentOS8 (with Python 3.6) so we will need also to wait for the transition to CentOS9-stream. |
synarete
force-pushed
the
ss-random-bytes
branch
from
1987149
to
17a5e4a
Compare
|
This particular PR is blocked because we do not use CentOS 9 which contains a newer version of python. This blocks the required test we run against xfs. |
synarete
force-pushed
the
ss-random-bytes
branch
2 times, most recently
from
66e943f
to
399bd76
Compare
synarete
force-pushed
the
ss-random-bytes
branch
from
399bd76
to
48586aa
Compare
Now that we may assume Python-version>=3.9, use standard 'random.randbytes' function to generate semi-random I/O testing data. Improve function's doc string; emphasize that this function is defined to avoid random-pool exhaustion on host machine. Tested with CentOS9-stream. Signed-off-by: Shachar Sharon <ssharon@ibm.com>
synarete
force-pushed
the
ss-random-bytes
branch
from
48586aa
to
63f32d7
Compare
anoopcs9
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we may assume Python-version>=3.9, use standard 'random.randbytes' function to generate semi-random I/O testing data. Improve function's doc string; emphasize that this function is defined to avoid random-pool exhaustion on host machine.