Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini cleanups #31

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

synarete
Copy link
Collaborator

Few minor cleanups to top-level tox.ini. Plus, passenv PYTHONPATH.

Shachar Sharon added 3 commits September 27, 2023 12:00
Let tox propagate PYTHONPATH environment variable. Should clear
confusing warning messages in newer tox versions.

Signed-off-by: Shachar Sharon <ssharon@ibm.com>
Run tox sub-commands from project's root directory, or else they may
fail due to wrong working-dir. In particular, when using tox directly
instead of via wrapper top-level Makefile (e.g.: Windows' PowerShell).

Signed-off-by: Shachar Sharon <ssharon@ibm.com>
Python uses 4-space for indentation. Follow same convention in tox.ini
configuration file.

Signed-off-by: Shachar Sharon <ssharon@ibm.com>
@anoopcs9 anoopcs9 changed the title tok.ini cleanups tox.ini cleanups Sep 27, 2023
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK, but I'm a little surprised they are needed. Are they mainly to run better on Windows systems?

@synarete
Copy link
Collaborator Author

Changes look OK, but I'm a little surprised they are needed. Are they mainly to run better on Windows systems?

@spuiuk requested to have passenv = PYTHONPATH (reduce tox warning). While at it, I added minor cleanups.
When executed via windows PowerSehll we should use tox directly instead of via wrapper Makefile hence it would be nice to ensure that we run at project's root dir.

Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@spuiuk spuiuk merged commit cdd45bf into samba-in-kubernetes:main Sep 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants