Allow test with already-mounted smbshare on local dir #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synarete
force-pushed
the
ss-local-testdir
branch
from
9b46fb0
to
00e577c
Compare
Shwetha-Acharya
approved these changes
Oct 16, 2023
@Shwetha-Acharya Please note that this PR is in conflict with your PR#38. Please wait for review comments from @spuiuk and @anoopcs9 before you begin your rebase. |
synarete
force-pushed
the
ss-local-testdir
branch
from
00e577c
to
8ee1863
Compare
added 3 commits
October 17, 2023 17:20
In cases where user may want to run (some) tests over existing smbshare, allow passing explicit 'test_dir' via 'test-info.yml' configuration file. It is up to the user to ensure that this value hold reference to valid (and mounted) samba share. May be used in Windows/PowerShell case where adding network device is done from outside of sit-test-cases. Signed-off-by: Shachar Sharon <ssharon@ibm.com>
Code cleanup: have single function for all sub-tests where already having a test-directory over SMB share. Signed-off-by: Shachar Sharon <ssharon@ibm.com>
Allow two modes of operation: if user provided explicit 'test_dir', use it for I/O consistency tests (assuming it is a valid smb share); otherwise, do the normal flow using cifs_mount/cifs_umount helper functions. Signed-off-by: Shachar Sharon <ssharon@ibm.com>
synarete
force-pushed
the
ss-local-testdir
branch
from
8ee1863
to
1b7ec40
Compare
|
commit 31b9e25 Closing this PR since this support is no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running over Windows, we should not execute the cifs_mount/cifs_umount helper functions. Instead, allow running mount tests over already existing smbshare directory, which the user attached via PowerShell's
net usecommand.