testcases: simplify test structure #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shwetha-Acharya
force-pushed
the
simplify-code
branch
from
4dd967a
to
ce833e6
Compare
anoopcs9
requested changes
Oct 13, 2023
pytest by default runs the functions preceeded with test keyword. As a result, all the required test functions will be executed. Hence, this PR simplifies the code by removing the unnecessary main block. Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Shwetha-Acharya
force-pushed
the
simplify-code
branch
from
ce833e6
to
ac4c2bf
Compare
|
I just rebased the change after resolving the conflict @anoopcs9 |
anoopcs9
approved these changes
Oct 13, 2023
We were obtaining test_info in two ways: 1. as a parameter from main 2. as a env variable Now that the main block is removed as redundance, this change eliminates the test_info occurrances initiated from main block and replaces it with the environment variable Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Shwetha-Acharya
added a commit
to Shwetha-Acharya/sit-test-cases
that referenced
this pull request
Oct 16, 2023
With this change, multiple test modules triggered from testcases/mount can be run as individual tests complying to pytest standards. Also any number of new tests can be added efficiently on the mount. Fixes: samba-in-kubernetes#30 depends on samba-in-kubernetes#34 Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest by default runs the functions preceeded with test keyword. As a result, all the required test functions will be executed. Hence, this PR simplifies the code by removing the unnecessary main block.