Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smbtorture/selftest: Add flapping.cephfs #36

Merged
merged 1 commit into from
Nov 9, 2023
Merged

smbtorture/selftest: Add flapping.cephfs #36

merged 1 commit into from
Nov 9, 2023

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Oct 13, 2023 •
edited
Loading

We have identified at least one sub test which we wish to skip the result rather than modifying the server each time for specific use cases. Therefore start with a dedicated flapping file for CephFS.

fixes #35

@anoopcs9 anoopcs9 requested a review from spuiuk October 13, 2023 11:50
@spuiuk spuiuk mentioned this pull request Oct 18, 2023
Closed
@spuiuk
Copy link
Collaborator

spuiuk commented Oct 18, 2023

Manually looking into the centos-ci test for cephfs

testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.rw] PASSED [ 50%]

I see other failing tests which need to be investigated separately.

=========================== short test summary info ============================
FAILED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.create]
FAILED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.session]
=================== 2 failed, 28 passed in 178.54s (0:02:58) ===================

spuiuk
spuiuk approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@spuiuk
Copy link
Collaborator

spuiuk commented Oct 19, 2023

/retest all

@spuiuk
Copy link
Collaborator

spuiuk commented Oct 23, 2023

The cephfs builds have been failing recently and seems to be unrelated to this particular PR.
samba-in-kubernetes/sit-environment#53

However to confirm that this change works, we need to be able to see a completed cephfs install. So leaving it at review mode while we fix the CI system for cephfs.

@spuiuk
Copy link
Collaborator

spuiuk commented Oct 24, 2023 •
edited by anoopcs9
Loading

/test centos-ci/cephfs

1 similar comment
@spuiuk
Copy link
Collaborator

spuiuk commented Nov 6, 2023

/test centos-ci/cephfs

@anoopcs9
smbtorture/selftest: Add flapping.cephfs
c16b97b 
We have identified at least one sub test which we wish to skip the
result rather than modifying the server each time for specific use
cases. Therefore start with a dedicated flapping file for CephFS.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Nov 9, 2023

The cephfs builds have been failing recently and seems to be unrelated to this particular PR. samba-in-kubernetes/sit-environment#53

This is now fixed.

However to confirm that this change works, we need to be able to see a completed cephfs install. So leaving it at review mode while we fix the CI system for cephfs.

Latest results:

=========================== short test summary info ============================
FAILED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.create]
FAILED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.session]
FAILED testcases/consistency/test_consistency.py::test_consistency[192.168.123.12-share-cephfs-default]
FAILED testcases/consistency/test_consistency.py::test_consistency[192.168.123.10-share-cephfs-default]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.compound_find]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.sharemode]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.durable-open-disconnect]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.deny]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.notify-inotify]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.maximum_allowed]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.sdread]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.winattr]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.rename]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.connect]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.mkdir]
PASSED testcases/smbtorture/test_smbtorture.py::test_smbtorture[share-cephfs-default-smb2.rw]

@anoopcs9 anoopcs9 merged commit 1afc759 into samba-in-kubernetes:main Nov 9, 2023
5 of 8 checks passed
@anoopcs9 anoopcs9 deleted the add-flapping-cephfs branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shwetha-Acharya Shwetha-Acharya Shwetha-Acharya approved these changes

@spuiuk spuiuk spuiuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CephFS: Failure in running smb2.rw tests
3 participants
@anoopcs9 @spuiuk @Shwetha-Acharya