metrics: always resolve all versions

Do not bail-out in case of failure to resolve any of the sub-component
versions but rather defer this failure to final status code. Required in
order to avoid partial versions-view as part of exported status metric.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

internal/metrics/versions.go

@@ -27,25 +27,26 @@ func UpdateDefaultVersions(version, commitid string) {
 // ResolveVersions is a best-effort to resolve current pod's versions info
 func ResolveVersions(clnt *kclient) (Versions, error) {
 	var err error
+	var status error
 	vers := Versions{
 		Version:  defaultVersions.Version,
 		CommitID: defaultVersions.CommitID,
 	}
 	if clnt != nil {
 		vers.SambaImage, err = resolveSambaImage(clnt)
 		if err != nil {
-			return vers, err
+			status = err
 		}
 	}
 	vers.SambaVersion, err = resolveSambaVersion()
-	if err != nil {
-		return vers, err
+	if err != nil && status != nil {
+		status = err
 	}
 	vers.CtdbVersion, err = resolveCtdbVersion()
-	if err != nil {
-		return vers, err
+	if err != nil && status != nil {
+		status = err
 	}
-	return vers, nil
+	return vers, status
 }
 
 func resolveSambaImage(clnt *kclient) (string, error) {