Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc fixes #12

Merged
merged 2 commits into from
Aug 5, 2024
Merged

misc fixes #12

merged 2 commits into from
Aug 5, 2024

Commits on Aug 5, 2024

  1. README: use proper port number 

    The current default smbmetrics port number is 9922. Reflect this in
top-level README file.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
    @synarete
    synarete committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f29cb81 View commit details
    Browse the repository at this point in the history

  2. metrics: always resolve all versions 

    Do not bail-out in case of failure to resolve any of the sub-component
versions but rather defer this failure to final status code. Required in
order to avoid partial versions-view as part of exported status metric.

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
    @synarete
    synarete committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    cbbbeb5 View commit details
    Browse the repository at this point in the history