Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs for unit in radio_telescope_layout.py? #57

Closed
FurenDeng opened this issue Dec 28, 2024 · 1 comment
Closed

Bugs for unit in radio_telescope_layout.py? #57

FurenDeng opened this issue Dec 28, 2024 · 1 comment

Comments

@FurenDeng
Copy link

In radio_telescope_layout.py, line 32-33 reads

    if isinstance(antll, u.quantity.Quantity):
        antll *= u.deg

I guess you want

    if not isinstance(antll, u.quantity.Quantity):
        antll *= u.deg

to attach unit.
BTW, I cannot understand line 76-77

    if isinstance(antxyz, u.quantity.Quantity):
        antxyz *= antxyz

which squares antxyz.

@sambit-giri
Copy link
Owner

Thank you for noticing these mistakes. The radio_telescope_layout.py is still under developement and, therefore, could have more bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants