Sockets to streams #210
Closed
Sockets to streams #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes beams socket protocol from the bidirectional sockets interface to a unidirectional streaming interface. This change was motivated by serveral practical issues with proxies that did not allow http request upgrades by default. The new approach uses streaming http bodies which should be supported by all regular proxies.
Threated
force-pushed
the
feat/rework-sockets
branch
from
0882f57 to
cec5122
Compare
Threated
force-pushed
the
feat/rework-sockets
branch
from
ee736a2 to
6cc7ecf
Compare
|
Reanaming the endpoint to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes beams socket protocol from the bidirectional sockets interface to a unidirectional streaming interface. This change was motivated by several practical issues with proxies that did not allow http request upgrades by default.
The new approach uses streaming http bodies which should be supported by all regular proxies.
Open questions:
/v1/socketsto/v1/stream[s]There seems to be a regression with the tasks endpoint