-
Notifications
You must be signed in to change notification settings - Fork 672
Add TLS support with ConnectTLS function #227
base: master
Are you sure you want to change the base?
Conversation
I don't understand the DeepSource error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like TLS can be implemented as a custom Dialer and injected via WithDialer(). That is a more minimal change that doesn't require any additional refactoring, just a relatively simple wrapper.
Given that TLS configs are often difficult to wire up correctly (particularly with a lot of complex reconnect code in the client here) including tests that cover TLS-enabled connections would improve confidence in the code change.
So I fixed the DeeSource Problems. |
# Conflicts: # .travis.yml # zk/server_java_test.go
# Conflicts: # .travis.yml # zk/server_java_test.go
This reverts commit f8506e5
Hello, |
Hello,
I added the function ConnectTLS to enable go-zookeeper
to connect to TLS protected zookeepers.
Also I did refactor the Connect func to prevent code redundancy.