Add eslint rule to forbid imports from path containing packages/ from…

… root dir of OSD (opensearch-project#1500)

* Add lint rule to forbid imports from packages

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add eslint rule to forbid imports from path containing packages/ from root dir of OSD

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>

.eslintrc.js

@@ -20,6 +20,18 @@ module.exports = {
   extends: ['@elastic/eslint-config-kibana', 'plugin:@elastic/eui/recommended'],
   rules: {
     // "@osd/eslint/require-license-header": "off"
+    '@osd/eslint/no-restricted-paths': [
+      'error',
+      {
+        basePath: __dirname,
+        zones: [
+          {
+            target: ['(public|server)/**/*'],
+            from: ['../../packages/**/*','packages/**/*']
+          },
+        ]
+      }
+    ]
   },
   overrides: [
     {

server/saved_objects/saved_objects_wrapper.ts

@@ -34,7 +34,6 @@ import {
   SavedObjectsUpdateOptions,
   SavedObjectsUpdateResponse,
 } from 'opensearch-dashboards/server';
-import { Config } from 'packages/osd-config/target';
 import { SecurityPluginConfigType } from '..';
 import { OpenSearchDashboardsAuthState } from '../auth/types/authentication_type';
 import {