From 5034f93ca9716d10b3b69a5d56cf42be32670cc9 Mon Sep 17 00:00:00 2001 From: Craig Perkins Date: Wed, 19 Jul 2023 09:03:38 -0400 Subject: [PATCH] Add eslint rule to forbid imports from path containing packages/ from root dir of OSD (#1500) * Add lint rule to forbid imports from packages Signed-off-by: Craig Perkins * Add eslint rule to forbid imports from path containing packages/ from root dir of OSD Signed-off-by: Craig Perkins --------- Signed-off-by: Craig Perkins Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Peter Nied Signed-off-by: Sam --- .eslintrc.js | 12 ++++++++++++ server/saved_objects/saved_objects_wrapper.ts | 1 - 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 03e09f2b0..2b5f80b11 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -20,6 +20,18 @@ module.exports = { extends: ['@elastic/eslint-config-kibana', 'plugin:@elastic/eui/recommended'], rules: { // "@osd/eslint/require-license-header": "off" + '@osd/eslint/no-restricted-paths': [ + 'error', + { + basePath: __dirname, + zones: [ + { + target: ['(public|server)/**/*'], + from: ['../../packages/**/*','packages/**/*'] + }, + ] + } + ] }, overrides: [ { diff --git a/server/saved_objects/saved_objects_wrapper.ts b/server/saved_objects/saved_objects_wrapper.ts index 5dae1fc5f..983356adb 100644 --- a/server/saved_objects/saved_objects_wrapper.ts +++ b/server/saved_objects/saved_objects_wrapper.ts @@ -34,7 +34,6 @@ import { SavedObjectsUpdateOptions, SavedObjectsUpdateResponse, } from 'opensearch-dashboards/server'; -import { Config } from 'packages/osd-config/target'; import { SecurityPluginConfigType } from '..'; import { OpenSearchDashboardsAuthState } from '../auth/types/authentication_type'; import {