Test with Rails 7.2 #560
Merged
Test with Rails 7.2 #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
cjcolvar
force-pushed
the
af_version
branch
3 times, most recently
from
262268b
to
0193a00
Compare
…tribute_methods This works around a change in Rails 7.2 which adds a module that comes before Hydra::AccessControls::Visibility in ancestor heirarchy so gets called before the accessor methods defined in the Visibility module.
cjcolvar
force-pushed
the
af_version
branch
from
97f98b4
to
e1761fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of samvera/maintenance#161
Also drop testing on unsupported ruby/rails versions
The one substantial change in this PR is refactoring the visibility methods into a submodule that gets included to workaround a timing issue with changes in ActiveModel's
define_attribute_methods.