Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary label fails to sort when specified using ldpath #288

Open
elrayle opened this issue Nov 21, 2019 · 0 comments · May be fixed by #284
Open

primary label fails to sort when specified using ldpath #288

elrayle opened this issue Nov 21, 2019 · 0 comments · May be fixed by #284

Comments

@elrayle
Copy link
Contributor

elrayle commented Nov 21, 2019

Description

Language processing in QA requires language tagged RDF::Literals. Without that, the sorting process is not able to sort by language and within language. Currently, the ldpath_service using the ldpath gem converts Literals to Strings.

See PR samvera-labs/ldpath#18 which adds the option to have ldpath return Literals.

Expected

When a config specifies an ldpath for the primary label, the label values will be sorted by language.

Actual

When a config specifies an ldpath for the primary label, the label values are not sorted by language.

Reproduce

Update the fixtures used by the language sorting tests (i.e. /spec/fixtures/authorities/linked_data/lod_lang*) to only use ldpath instead of predicates.

This will cause multiple tests to fail.

@elrayle elrayle changed the title ldpath service returns strings instead of RDF::Literals primary label fails to sort when specified using ldpath Nov 21, 2019
@elrayle elrayle linked a pull request Nov 21, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant