From c444bda21078553b3f9f30482758901a668f093c Mon Sep 17 00:00:00 2001 From: samypr100 <3933065+samypr100@users.noreply.github.com> Date: Sun, 12 May 2024 11:47:30 -0400 Subject: [PATCH] breaking: switch to dynamic drive type by default for flexibility --- .github/workflows/main.yml | 2 +- README.md | 13 ++++++++----- action.yml | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 979657e..92499d2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -59,7 +59,7 @@ jobs: with: drive-size: 2GB drive-format: NTFS - drive-type: Dynamic + drive-type: Fixed drive-path: "my_awesome_drive.vhdx" workspace-copy: true diff --git a/README.md b/README.md index 5741039..5a53679 100644 --- a/README.md +++ b/README.md @@ -18,13 +18,13 @@ this action creates for you. Just add the following line to the `steps:` list in your GitHub Actions yaml: ```yaml -- uses: samypr100/setup-dev-drive@v1 +- uses: samypr100/setup-dev-drive@v2 ``` You can optionally pass parameters to the action as follows: ```yaml -- uses: samypr100/setup-dev-drive@v1 +- uses: samypr100/setup-dev-drive@v2 with: drive-size: 1GB drive-format: ReFS @@ -59,10 +59,13 @@ otherwise `workspace-copy` can cause issues. #### `drive-type` Determines the type of drive, `Fixed` or `Dynamic`. There are performance tradeoffs between -both, hence for the purposes of this action `Fixed` is used by default. +both. For the purposes of this action `Dynamic` is used by default for flexibility. + `Dynamic` is useful when you want to cache the disk across job runs as it yields a smaller payload to cache when the job ends. +`Fixed` gives you a notable performance boost, but there's a small creation overhead. + #### `workspace-copy` This copies `${{ github.workspace }}` to your Dev Drive. Usually when you use `actions/checkout` @@ -90,7 +93,7 @@ your dev drive workspace will be `E:\` by default assuming the dri ```yaml - uses: actions/checkout@v4 -- uses: samypr100/setup-dev-drive@v1 +- uses: samypr100/setup-dev-drive@v2 with: workspace-copy: true - name: Install Dependencies @@ -99,7 +102,7 @@ your dev drive workspace will be `E:\` by default assuming the dri ``` ```yaml -- uses: samypr100/setup-dev-drive@v1 +- uses: samypr100/setup-dev-drive@v2 - name: "Install Rust toolchain in dev drive" env: CARGO_HOME: ${{ env.DEV_DRIVE }}/.cargo diff --git a/action.yml b/action.yml index 0b393d0..3338e7c 100644 --- a/action.yml +++ b/action.yml @@ -16,7 +16,7 @@ inputs: default: "dev_drive.vhdx" drive-type: description: "Determines whether all space is allocated initially or over time. Example: Fixed or Dynamic." - default: "Fixed" + default: "Dynamic" workspace-copy: description: "Copy your GITHUB_WORKSPACE checkout to your Dev Drive. Examples: true, false." default: "false"