Home / Search page #45
Conversation
BREAKING CHANGE: modify schema
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looking 🔥 so far! We might wanna do a few changes I recommended and then we can get this merged. 🚀
Edit: Another small observation, the header is a little too squished on smaller devices and the search bar component is also cut off partially. Could you possibly also improve the responsiveness on smaller devices? 🤩
src/styles/globals.css
Outdated
| @@ -33,6 +33,8 @@ | |||
| --ring: 222.2 84% 4.9%; | |||
|
|
|||
| --radius: 0.5rem; | |||
|
|
|||
| --font-sans: "BentonSans"; | |||
There was a problem hiding this comment.
I'm slightly unsure if this will actually apply the font. See ~/app/layout.tsx. We are already applying Inter as a font. In order to apply a custom font, we may have to import and use the .woff2 file that @michellewu13 sent using the localFonts(...) function.
See: Optimizing: Fonts
There was a problem hiding this comment.
yeah that makes sense, I don't see where the file is so maybe we can do that during standup on thrusday
|
Looks like vercel still works with the auth change 🙏 |
There was a problem hiding this comment.
LGTM 🚀 I don't think I fully understand how localFont works, especially when using multiple font variants, but we can probably work on that as a different ticket. Seems like the font currently being used is the default serif font (not Benton Sans). However, we can merge this for now!
Description
I wanted to make a smaller PR to avoid making massive ones. The changes here are that I've made a home screen according to the LoFi + HiFi in the figma. It is not yet mobile responsive since there is no design for that yet, but this can be a ticket in the future.
I also made a header component that we can update in the future.
I also made some changes in the tailwind config. I figured since we are going to have to change inline colors for this in the future anyways, might as well play around with this. We can probably discuss with designers what the color palette is going to be so we can fill that out properly.
Checklist