Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: begin creating Role Review Cards #50

Merged
merged 8 commits into from
Mar 31, 2024
Merged

feat: begin creating Role Review Cards #50

merged 8 commits into from
Mar 31, 2024

Conversation

banushi-a
Copy link
Contributor

@banushi-a banushi-a commented Mar 23, 2024

Progress for #44

Description

New Features

  • Roles Page
    • add /roles to the end of the url
    • Made up of "Role Review Cards". These are in role-review-card.tsx - potentially the messiest file currently in the code base ◡̈
      • The stars are a separate component called review-card-stars.tsx
    • Currently just fetching all of them since this is a longer ticket
Screenshot 2024-03-26 at 12 15 25 AM
  • Header Layout Component
    • If you switch to the companies page /companies, you will notice that the search bar is at the same position. This is because I abstracted how the header was placed into the header-layout.tsx file.
    • Edited cooper logo bc alignment was off from when I copied svg from figma.
      • Also updated favicon
    • Header color + font was different in design, so I changed those as well
    • Changed color of login / logout button even though it isn't necessary since they are temp but they were bothering me lol
Screenshot 2024-03-26 at 12 19 49 AM
  • Search Filter
    • I've been calling that whole block with all the search functionality the "search filter" while the white bar is the "search bar" btw
    • It is more responsive now 😈
    • Added cooper peeking over (my fav change)

That's about all have fun reviewing lollll

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 8:05pm

Made role review cards update based on db, put together components for roles page, made search bar
slightly more responsive, updated header logo sizing, edited logo font per design
src/app/layout.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT! Most of my comments are nitpicks tbh, so feel free to not make all of the requested changes.

src/components/role-review-card.tsx Show resolved Hide resolved
Copy link
Contributor

@cinyecai cinyecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ate

Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT! Let's merge this before this PR blows up with more file changes. 🚀

@banushi-a banushi-a merged commit 55a7d93 into main Mar 31, 2024
4 checks passed
@banushi-a banushi-a deleted the review-cards branch March 31, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants