-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing session cookies #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
owens1127
commented
Oct 23, 2024
owens1127
commented
Oct 26, 2024
packages/trpc/src/procedures/auth.ts
Outdated
} | ||
|
||
const hashedPassword = await hashPassword(input.password); | ||
|
||
const user = await ctx.prisma.user.create({ | ||
const userWithSesion = await ctx.prisma.user.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userWithSession
ispapa
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the auth flow to read and write from cookies.
Description
This PR updates the existing auth flow to set, read, and delete cookies in the proper place.
This PR also adds an abundance of tests to ensure solid coverage on these routes, will also serving as a good example
Motivation and Context
In order to implement auth, we need to store the sessionId in the user's cookies.
Closes Cookies
Screenshots (if appropriate):
Types of changes
Checklist:
How has this been tested?
Added a large number of integration tests