Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new env package #17

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Create new env package #17

merged 4 commits into from
Oct 30, 2024

Conversation

owens1127
Copy link
Contributor

@owens1127 owens1127 commented Oct 29, 2024 •
edited
Loading

Description

  • Creates a new env package
  • restricts env import to be done after validation

Closes cleanup env

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD changes (changing github actions or deployment scripts)
  • Database migration
  • Environment variable change
  • New package(s)
  • New dependencies
  • Global style changes
  • Project configuration

Checklist:

  • I verified my changes work in the local environment
  • I verified my changes work in the preview environment
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

How has this been tested?

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dog-licensing-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 7:02pm

@owens1127 owens1127 changed the title Env Create new env package Oct 30, 2024
@owens1127 owens1127 marked this pull request as ready for review October 30, 2024 23:24
jpraissman
jpraissman approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jpraissman jpraissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owens1127 owens1127 merged commit 58c66a4 into main Oct 30, 2024
7 checks passed
@owens1127 owens1127 deleted the env branch October 30, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraissman jpraissman jpraissman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owens1127 @jpraissman