search results include accurate year and season

however, a lot of theses more accurate links lead to nothing in nusearch
sandboxnu · Oct 3, 2024 · 78fee84 · 78fee84
1 parent bdf77e5
commit 78fee84
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/packages/frontend/components/AddCourseModal/AddCourseModal.tsx b/packages/frontend/components/AddCourseModal/AddCourseModal.tsx
@@ -13,7 +13,7 @@ import {
   Text,
   VStack,
 } from "@chakra-ui/react";
-import { NUPathEnum, ScheduleCourse2 } from "@graduate/common";
+import { NUPathEnum, ScheduleCourse2, SeasonEnum } from "@graduate/common";
 import { useState } from "react";
 import { useSearchCourses } from "../../hooks";
 import {
@@ -33,6 +33,7 @@ import { SecondaryButton } from "../Button";
 interface AddCourseModalProps {
   isOpen: boolean;
   catalogYear?: number;
+  season: SeasonEnum;
   addTo: string;
   /** Function to close the modal UX, returned from the useDisclosure chakra hook */
   closeModalDisplay: () => void;
@@ -50,6 +51,7 @@ interface AddCourseModalProps {
 export const AddCourseModal: React.FC<AddCourseModalProps> = ({
   isOpen,
   catalogYear,
+  season,
   addTo,
   closeModalDisplay,
   isCourseAlreadyAdded,
@@ -227,6 +229,8 @@ export const AddCourseModal: React.FC<AddCourseModalProps> = ({
                       (course) => (
                         <SearchResult
                           key={getCourseDisplayString(course)}
+                          year={catalogYear}
+                          season={season}
                           course={course}
                           addSelectedCourse={addSelectedCourse}
                           isResultAlreadyAdded={isCourseAlreadyAdded(course)}

diff --git a/packages/frontend/components/AddCourseModal/SearchResult.tsx b/packages/frontend/components/AddCourseModal/SearchResult.tsx
@@ -9,6 +9,8 @@ import { getSearchLink } from "../ScheduleCourse";
 
 interface SearchResultProps {
   course: ScheduleCourse2<null>;
+  year: number | undefined;
+  season: SeasonEnum;
   addSelectedCourse: (course: ScheduleCourse2<null>) => Promise<void>;
   isResultAlreadySelected: boolean;
   isResultAlreadyAdded: boolean;
@@ -19,6 +21,8 @@ interface SearchResultProps {
 
 export const SearchResult: React.FC<SearchResultProps> = ({
   course,
+  year,
+  season,
   addSelectedCourse,
   isResultAlreadySelected,
   isResultAlreadyAdded,
@@ -52,7 +56,7 @@ export const SearchResult: React.FC<SearchResultProps> = ({
         </Box>
         <Box ml="auto" mr="sm"></Box>
         <a
-          href={getSearchLink(2022, SeasonEnum.FL, course)}
+          href={getSearchLink(year ?? 2022, season, course)}
           target="_blank"
           rel="noreferrer"
         >

diff --git a/packages/frontend/components/Plan/ScheduleTerm.tsx b/packages/frontend/components/Plan/ScheduleTerm.tsx
@@ -87,6 +87,7 @@ export const ScheduleTerm: React.FC<ScheduleTermProps> = ({
       ))}
       <AddCourseButton onOpen={onOpen} />
       <AddCourseModal
+        season={scheduleTerm.season}
         isOpen={isOpen}
         catalogYear={catalogYear}
         addTo={getSeasonDisplayWord(scheduleTerm.season)}