Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional rendering for 'email not verified' in account overview #624

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conditional rendering for 'email not verified' in account overview #624

merged 1 commit into from
Sep 21, 2023

Conversation

daisykucharski
Copy link
Contributor

@daisykucharski daisykucharski commented Sep 17, 2023 •
edited
Loading

Description

Added conditional rendering for the send email verification link in the account overview

Closes #622

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Shows tool tip when email has not been verified
  • Doesn't show tool tip when email is verified

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

BrandonLim8890
BrandonLim8890 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM SUCH CLEAN CODE 🚀

@daisykucharski daisykucharski merged commit 82f0d05 into main Sep 21, 2023
4 checks passed
@daisykucharski daisykucharski deleted the daisy/conditional-render-email-verified branch September 21, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonLim8890 BrandonLim8890 BrandonLim8890 approved these changes

Assignees

@daisykucharski daisykucharski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional rendering for 'email not verified' in account overview
2 participants
@daisykucharski @BrandonLim8890