Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User transfer courses when generating pre-req errors (#613) #628

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

yijen-sun
Copy link
Contributor

@yijen-sun yijen-sun commented Oct 1, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #613

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Manually tested

Adding a course that requires a pre-req (ex: Interdisciplinary Advanced Writing in the Disciplines), and making sure the pre-req error disappears when adding the required course in Transfer Courses (ex: First Year Writing).

Transfer courses should not apply to co-reqs, only pre-reqs.

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@dkd2101 dkd2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything makes sense to me! Tested it on my end with multiple different majors and everything seems to check out. Nice job!

ScheduleTerm2,
TermError,
} from "@graduate/common";

export const getCoReqWarnings = (
schedule: Schedule2<unknown>
schedule: Schedule2<unknown>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was prettier run before the PR?

@yijen-sun yijen-sun merged commit e377149 into main Oct 19, 2023
4 checks passed
@yijen-sun yijen-sun deleted the transfer-courses-req-errors branch October 19, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use transfer courses when generating course req errors
4 participants