Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full name instead of first/last #635

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

daisykucharski
Copy link
Contributor

@daisykucharski daisykucharski commented Oct 22, 2023

Description

Removed references to first/last name in FE and replace it with full name.

There's also some formatting changes (RIP)

Closes #583

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Screenshot 2023-10-22 at 2 15 17 PM Screenshot 2023-10-22 at 2 15 27 PM Screenshot 2023-10-22 at 2 15 44 PM

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@daisykucharski daisykucharski requested review from dkd2101, DylanCerenov and BrandonLim8890 and removed request for dkd2101 October 22, 2023 19:16
Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small stylistic thing. I don't like the tooltip below the fullname now because it looks like it disrupts the flow. Maybe have it above? Would like Angela/Elaine's thoughts

@daisykucharski daisykucharski merged commit a719fbe into main Nov 2, 2023
4 checks passed
@daisykucharski daisykucharski deleted the daisyk/standardize-names-fe branch November 2, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize how full name is validated and handles in update student and signup
2 participants