Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates #636

Merged
merged 32 commits into from
Nov 8, 2023
Merged

UI updates #636

merged 32 commits into from
Nov 8, 2023

Conversation

AngelaZQ1
Copy link
Contributor

@AngelaZQ1 AngelaZQ1 commented Oct 22, 2023

Description

Made the following UI modifications:

  • lighten sidebar bg color (will match the sidebar in the new add course modal) and added a right border
  • lighten bg color of ScheduleTerm
  • update "Add Course" button colors
  • decrease blue button and delete plan button border to .5px
  • decrease spacing between input label and input box
  • change lg input sizes to md for consistency
  • moved the "no major" checkbox to the left of the text
  • added a + icon to the add year button
  • removed an extra '"' from the error modal
  • italicized the SectionRequirement text
  • decrease spacing between "graduate" and "your way" on home page

Also updated the primary.neutral colors in the theme folder to remove unused grays and replace some with the names used in figma (gray0, gray, gray2, gray3). primary.neutral.main was replaced with primary.neutral.gray.

Old:
Screenshot 2023-10-22 at 2 39 16 PM

New:
Screenshot 2023-10-22 at 2 39 02 PM

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@daisykucharski daisykucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus a few nits

packages/frontend-v2/components/Plan/TransferCourses.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHUNGUS CHANGES WE LOVE A DESIGNER THAT CAN CODE. Just some small nits here and there but the biggest thing is to create a "theme" with the styling we write. So instead of specifying 1px for borders or for spacing in multiple components, we can just define it within a file and call 3xs for example. This standardizes our code, so that when we get designs from you guys, we can even just say that a border/padding/spacing is simply s, m, l etc. You can add to this file here.

packages/frontend-v2/components/Form/Select.tsx Outdated Show resolved Hide resolved
packages/frontend-v2/components/Header/AccountOverview.tsx Outdated Show resolved Hide resolved
packages/frontend-v2/utils/theme/index.ts Outdated Show resolved Hide resolved
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Nov 6, 2023 4:00pm

Comment on lines 55 to 58
300: "#f4f6f9",
400: "#7586a0",
700: "#e2e6ec",
900: "#d2d8e2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 and 700 arent used, 900 is basically gray2, and changed 400 to gray4

Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, once you change it you can merge! 💯

700: "#e2e6ec",
800: "#1f242c",
900: "#d2d8e2",
gray0: "#f4f6f9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just change these to gray.0. So like gray would be its own object. This way we aren't doing gray0, gray1. It would instead be gray.50, or gray.100

Copy link
Contributor Author

@AngelaZQ1 AngelaZQ1 Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh gotcha i see what you mean now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be fine to just do neutral.100 instead of neutral.gray.100 since neutral is just gonna be for grays?

Copy link
Contributor

@BrandonLim8890 BrandonLim8890 Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea if we feel like there wouldn't be anymore neutrals, then this works. Just saw the changes, you can merge whenever

@AngelaZQ1 AngelaZQ1 merged commit 374808b into main Nov 8, 2023
5 of 6 checks passed
@AngelaZQ1 AngelaZQ1 deleted the ui-updates branch November 8, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants