Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "passwordConfirm" to Logging Denylist #646

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

AlpacaFur
Copy link
Member

Description

We are currently logging the passwordConfirm field production which is bad security practice. This PR removes the field by adding it to the denylist.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Copy link
Contributor

@rael346 rael346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol approved

@AlpacaFur AlpacaFur merged commit 57af9f6 into main Oct 29, 2023
4 checks passed
@AlpacaFur AlpacaFur deleted the luke/password-logging-hotfix branch October 29, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants