Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Courses in sidebar will display a checkmark if they are present anywhere in the users plan #783

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

23langloisj
Copy link
Contributor

Description

Added a new prop to the SectionRequirement so that once all the courses are rendered they can check if they exist in the student's plan. If they do, then they will be displayed with a checkmark.

Closes # 776

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Screenshot 2024-11-24 at 5 23 05 PM

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

…n and check if a course in the sidebar needs a checkmark
@23langloisj 23langloisj self-assigned this Nov 24, 2024
Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 2:28am

@23langloisj 23langloisj requested a review from KobeZ123 November 24, 2024 22:23
coursesTaken.forEach((course) => {
if (
requirement.type === "COURSE" &&
course.classId === requirement.classId.toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

courseID is like 2500, so if CS2500 is added, it would say another class like GAME2500 is added
image

Copy link
Contributor

@KobeZ123 KobeZ123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@KobeZ123 KobeZ123 merged commit f20fcb2 into main Dec 5, 2024
7 checks passed
@KobeZ123 KobeZ123 deleted the individual-course-check branch December 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants