Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup + documentation + frontend error handling for missing blobs + remove temporary form signing implementation + Remove NextAuth + Set NODE_ENV #142

Closed
wants to merge 12 commits into from

Conversation

kaiyangzheng
Copy link
Collaborator

@kaiyangzheng kaiyangzheng commented Sep 10, 2024

Description

  • Cleaned up dead code that we weren't using anymore
  • Documented frontend functionality and standardized naming conventions
  • Handled errors when blobs can't load since that is currently broken
  • Removed old form signing implementation
  • Remove NextAuth and add username + password form to sign in
  • Added NODE_ENV to backend .env.example and do not send email using postmark when NODE_ENV=development (This is set to production when deployed)

Motivation and Context

  • Make code easier to read and understand
  • Gracefully handle errors where the web app previously crashed
  • Moving toward new implementation for form signing and authentication, so remove dead code
  • Remove usage of certain resources (such as postmark) when developing

Closes [#136] and [#141]

How has this been tested?

Manually tested in web app and called postmark API endpoint.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:36am

@kaiyangzheng
Copy link
Collaborator Author

nvm I'll probably make separate PRs for this

@kaiyangzheng kaiyangzheng removed the request for review from ahweigl September 10, 2024 13:13
@@ -419,7 +419,7 @@ async function main() {
id: ANSHUL_SHIRUDE_UUID,
firstName: 'Anshul',
lastName: 'Shirude',
email: 'email1@kaiyangzhenggmail.onmicrosoft.com',
email: 'shirude.a@northeastern.edu',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anshul abt to get doxxed 😨

This was unlinked from issues Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants