-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
165 feature user registration after azure login #171
165 feature user registration after azure login #171
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…into 165-feature-user-registration-after-azure-login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it might be better to have finding in a separate function that both findOneByName and findOrCreateOneByName use, just so the logic is only in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is easily doable but I think for the sake of keeping the service logic explicit/clear the same query can exist in both functions, it's only a few lines + there's a subtle difference in making the department
variable mutable ie let department =
in findOrCreateOneByName
so that it can be overwritten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation and Context
Closes [#152]
How has this been tested?
Logging in user and making sure appropriate database rows are created.
Screenshots (if appropriate):
Types of changes
Checklist: