172 feature reconfigure form signing approving and category logic #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 172-feature-reconfigure-form-signing-approving-and-category-logic
kaiyangzheng
requested review from
ahweigl,
Gayatri-K26,
DonnyLe and
laurenbrissette
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elvincheng3
reviewed
Oct 22, 2024
| @@ -120,6 +122,7 @@ export const AuthProvider = ({ children }: any) => { | |||
| login, | |||
| logout, | |||
| }), | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
…g form instance as approved
ahweigl
approved these changes
Oct 23, 2024
| @@ -120,6 +122,7 @@ export const AuthProvider = ({ children }: any) => { | |||
| login, | |||
| logout, | |||
| }), | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
kaiyangzheng
deleted the
172-feature-reconfigure-form-signing-approving-and-category-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update useForm hook to set todo, pending, and completed forms correctly:
Todo
Pending
Completed
Update frontend to reflect needs approval status.
Motivation and Context
Reduce confusion of those categories and make it consistent with what client wants.
Closes [#172]
How has this been tested?
Created, signed, and approved forms with various edge cases.
Screenshots (if appropriate):
Types of changes
Checklist:
Additional Context
This change assumes that we can only assign a user to sign a form once.