Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137 write and fix tests part 1/? - signature-fields #182

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

ahweigl
Copy link
Contributor

@ahweigl ahweigl commented Nov 2, 2024

Description

Motivation and Context

Part 1/? of test rewrites-- this PR includes new tests for signature-fields.service and signature-fields.controller -- these ones are unaffected by recent merges to main so pushing these first, not sure if the coverage on these is spotless but eh.

Closes [#137]

How has this been tested?

run yarn test

Screenshots (if appropriate):

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [X ] I have added tests to cover my changes.
  • [X ] All new and existing tests passed.

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 0:35am

Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@kaiyangzheng kaiyangzheng merged commit 4b30fff into main Nov 3, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the signaturefield-test branch November 3, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants