158 feature navbar design update 1 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Gayatri-K26
requested review from
kaiyangzheng,
ahweigl,
DonnyLe and
laurenbrissette
|
@Gayatri-K26 (this is a good practice for any frontend changes) can you include a screenshot in your PR summary of the changes so we can see without having to check out the branch? also it looks like there are merge conflicts and there were a lot of changes to the package/yarn files, maybe try running a fresh |
laurenbrissette
previously approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the nav bar icons (everything but the active home button looks correct). Also fixed the centering of the tiny text museum of fine arts on the bottom of the nav bar.