Authentication service/tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 11ced20.
| AuthModule, | ||
| PassportModule, | ||
| JwtModule.register({ | ||
| secret: process.env.JWT_SECRET, |
There was a problem hiding this comment.
What does secret mean?
There was a problem hiding this comment.
it's what's used to generate the jwt token and decode it
| if (user?.pswdHash && !(await bcrypt.compare(pass, user.pswdHash!))) { | ||
| return null; | ||
| } | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Is this for eslint? Do we need to keep this line?
There was a problem hiding this comment.
we're basically splitting out the password from the object and using js destructuring to do it, but that means we have an unused variable that eslint complains abt. just telling eslint to ignore this one line for that error
AnshulShirude
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Problem
Closes Authentication service/tests
Add basic auth groundwork.
Solution
Add basic auth groundwork.
Dependencies
[X] This PR adds new dependencies
Testing
Please describe how you tested this PR (manually and/or automatically)
Provide instructions so we can reproduce, and include screenshots of UI changes.