"Sign" form #76
Merged
"Sign" form #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahweigl
previously approved these changes
Dec 6, 2023
There was a problem hiding this comment.
couple formatting questions w this part
- should the button to sign this form be grayed out or blue? I think it'd make sense for it to be colored so it indicates I need to sign it but also haven't looked at the hi-fis for what this is supposed to look like
- alignment on the approve button looks wonky, should it right-align with the end of the "already signed" text?
- is "already signed" the phrasing we want, or would something simpler like just "signed" make more sense?
There was a problem hiding this comment.
realized there must not be a default height set for the assignee dropdown scrollable list, cuz when making a form w just one assignee and when opening the dropdown, it cuts off (which is my b for not noticing that on my PR lol)
ahweigl
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Problem
Closes story
Support signing a form.
Solution
Form signing
Dependencies
[ ] This PR adds new dependencies
Testing
Please describe how you tested this PR (manually and/or automatically)
Provide instructions so we can reproduce, and include screenshots of UI changes.