Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postmark setup- email for notifying admin on user sign #99

Merged
merged 21 commits into from
Mar 23, 2024

Conversation

ahweigl
Copy link
Contributor

@ahweigl ahweigl commented Mar 23, 2024

Description/Problem

Postmark setup + notifying admin when user signs form
**NOTE: employee 1 in seed file will need to be changed w/ iris' info for demo

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Solution

What did you change?
signFormInstance in form-instance-service

Dependencies

[ ] This PR adds new dependencies

Testing

Please describe how you tested this PR (manually and/or automatically)
Provide instructions so we can reproduce, and include screenshots of UI changes.

  • Manual Tests?
    • Sent a ton of emails lol

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 11:35pm

Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just delete some comments and logs

AnshulShirude
AnshulShirude previously approved these changes Mar 23, 2024
Copy link
Contributor

@AnshulShirude AnshulShirude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left the one question.

apps/server/prisma/seed.ts Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Mar 23, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9631676 Triggered Postmark Token d4b491b .github/workflows/main.yml View secret
9631676 Triggered Postmark Token ef0bc79 .github/workflows/main.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kaiyangzheng kaiyangzheng merged commit 3597bfc into main Mar 23, 2024
5 of 7 checks passed
kaiyangzheng added a commit that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants