Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact v4 #95

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Artifact v4 #95

merged 4 commits into from
Jan 13, 2025

Conversation

gq1
Copy link
Member

@gq1 gq1 commented Jan 6, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jan 6, 2025

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d5544ae

+| ✅ 125 tests passed       |+
#| ❔  26 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-variantcalling_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-variantcalling_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-variantcalling_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-variantcalling_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-variantcalling_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-variantcalling_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/variantcalling/variantcalling/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2025-01-06 14:10:47

@gq1 gq1 requested review from tkchafin and muffato January 6, 2025 14:15
@gq1
Copy link
Member Author

gq1 commented Jan 6, 2025

@tkchafin Can you have a look at this very small changes?
The failed CI test is not caused by this changes. I think some modules being updated in dev branch but calling them in workflow not being update. You may already have fixed somewhere else, I won't do any changes related to the test in this PR.

@tkchafin tkchafin changed the base branch from dev to ci January 13, 2025 12:05
@tkchafin tkchafin merged commit 4c0d971 into ci Jan 13, 2025
4 of 6 checks passed
@tkchafin tkchafin deleted the artifact-v4 branch January 13, 2025 12:05
@gq1
Copy link
Member Author

gq1 commented Jan 13, 2025

These changes should come from nf-core template and they probably fixed it as well.
nf-core/tools#3237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants