Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Disable deploy button during build time #6

Open
mornir opened this issue Mar 23, 2020 · 4 comments
Open

[Improvement] Disable deploy button during build time #6

mornir opened this issue Mar 23, 2020 · 4 comments
Labels
🔮 Feature Request New feature or request

Comments

@mornir
Copy link

mornir commented Mar 23, 2020

When I see the Netlify build logs from my clients, I see that they triggered multiple builds in a very short time span. For example, one of the websites takes about 2 minutes to build and the logs show something like 12:03, 12:05, 12:07.
I suspect that they click several times (by accident) on the deploy button, which queues up deploy commands.
From my testing, double-clicking the deploy button doesn't trigger two builds. However, after ~10 seconds, it will trigger a new build.

I propose to disable the deploy button right after clicking on it and to enable again at after the build has completed.

What do you think? Have you fellow devs run into a similar issue with clients?

@nemethricsi
Copy link

good idea! should we / can we help on this?

When I see the Netlify build logs from my clients, I see that they triggered multiple builds in a very short time span. For example, one of the websites takes about 2 minutes to build and the logs show something like 12:03, 12:05, 12:07.
I suspect that they click several times (by accident) on the deploy button, which queues up deploy commands.
From my testing, double-clicking the deploy button doesn't trigger two builds. However, after ~10 seconds, it will trigger a new build.

I propose to disable the deploy button right after clicking on it and to enable again at after the build has completed.

What do you think? Have you fellow devs run into a similar issue with clients?

@RamZallan
Copy link

RamZallan commented May 13, 2021

Bump, this would be really helpful! CC @rexxars

@opexchanger
Copy link

I had the same problem just now, the button doesn't seem to indicate clearly that the click worked, so it can end up queuing more than one build.

@sjelfull
Copy link
Member

Thanks for suggesting this feature, we will keep it in mind!

The complication today is that we don't poll for updates, since the badge takes care of displaying the deploy state.

@sjelfull sjelfull added the 🔮 Feature Request New feature or request label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants