fix: improve the handling of the observable query subscription

sanity-io · Mar 23, 2021 · e951cb2 · e951cb2
1 parent 4251fbe
commit e951cb2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/useSecrets.ts b/src/useSecrets.ts
@@ -10,17 +10,16 @@ export function useSecrets<T>(namespace: string) {
 
   const id = `secrets.${namespace}`;
 
-  let subscription: any;
   useEffect(() => {
-    subscription = client.observable
+    let subscription = client.observable
       .listen(query, { id }, { visibility: 'query' })
       .subscribe((result: Record<string, any>) => {
         setSecrets(result?.result?.secrets);
       });
     return () => {
       subscription.unsubscribe();
     };
-  }, []);
+  }, [id]);
 
   useEffect(() => {
     async function fetchData() {
@@ -30,7 +29,7 @@ export function useSecrets<T>(namespace: string) {
         .finally(() => setLoading(false));
     }
     fetchData();
-  }, []);
+  }, [id]);
 
   const storeSecrets = (secrets: T) => {
     setLoading(true);