Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Visual Editing. #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daveli
Copy link

@daveli daveli commented Jun 13, 2024

👋 This PR upgrades the template to Astro 4 and Sanity 3.46 with support for visual editing.

@daveli daveli requested a review from a team as a code owner June 13, 2024 14:15
Copy link

vercel bot commented Jun 13, 2024

@daveli is attempting to deploy a commit to the Sanity Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented Jun 13, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
template-astro-clean ❌ Failed (Inspect) Jun 28, 2024 7:36am

@christianhg
Copy link
Contributor

christianhg commented Jun 28, 2024

Hi @daveli ! Thanks a lot for this!

The PR was a bit much to take in (too many unrelated changes at once) so I decided to upgrade the relevant dependencies in #34

I took the liberty to rebase your branch to resolve the resulting merge conflicts caused by merging #34 – I hope that's alright with you.

Now, your PR is more focused on adding Visual Editing support to the template, which is great! Could you help me out and remove the rest of the unrelated changes? For dependencies, we probably just need to add @sanity/visual-editing by now and not pin or downgrade other dependencies. Also, I'm unsure the change to the node version strictly relevant to this PR.

Thanks!

@daveli
Copy link
Author

daveli commented Jun 28, 2024

👋 I have updated the PR to only include the changes to support Visual Editing. I will create a different PR to address the loading of environment variables once this one is merged 😎

@daveli daveli force-pushed the feature/update-dependencies branch from 92db766 to 3ea52c1 Compare June 28, 2024 12:40
@daveli daveli changed the title Upgrade to Astro 4 and Sanity 3.46.0. Also included support for Visual Editing. Add support for Visual Editing. Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants