-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Visual Editing. #46
base: main
Are you sure you want to change the base?
Conversation
@daveli is attempting to deploy a commit to the Sanity Team on Vercel. A member of the Team first needs to authorize it. |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6e6b9fc
to
9d3b4d6
Compare
Hi @daveli ! Thanks a lot for this! The PR was a bit much to take in (too many unrelated changes at once) so I decided to upgrade the relevant dependencies in #34 I took the liberty to rebase your branch to resolve the resulting merge conflicts caused by merging #34 – I hope that's alright with you. Now, your PR is more focused on adding Visual Editing support to the template, which is great! Could you help me out and remove the rest of the unrelated changes? For dependencies, we probably just need to add Thanks! |
9d3b4d6
to
92db766
Compare
👋 I have updated the PR to only include the changes to support Visual Editing. I will create a different PR to address the loading of environment variables once this one is merged 😎 |
92db766
to
3ea52c1
Compare
👋 This PR upgrades the template to Astro 4 and Sanity 3.46 with support for visual editing.