Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we send a close frame unless the socket is already closed #16

Open
sanmiguel opened this issue Dec 15, 2014 · 1 comment
Open

Ensure we send a close frame unless the socket is already closed #16

sanmiguel opened this issue Dec 15, 2014 · 1 comment
Labels
ready
Milestone
2.0

Comments

@sanmiguel
Copy link
Owner

As pr PR #15 encode_and_send/2 sometimes returns {error, closed}.

We should allow this in the case where we're trying to close, rather than asserting ok
@sanmiguel sanmiguel mentioned this issue Dec 15, 2014
Merged
@sanmiguel sanmiguel modified the milestones: 1.0, 2.0 Jul 20, 2015
@sanmiguel
Copy link
Owner Author

This is best solved by altering the FSM to include the CLOSING and CLOSED states as per #17

@sanmiguel sanmiguel mentioned this issue Jul 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@sanmiguel