Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add minimum viable API for commitments #368

Merged
merged 5 commits into from
Oct 17, 2023
Merged

add minimum viable API for commitments #368

merged 5 commits into from
Oct 17, 2023

Conversation

majewsky
Copy link
Contributor

@majewsky majewsky commented Oct 16, 2023 •
edited
Loading

@VoigtS Please take a look. This should be enough API to allow your work to progress.

This PR is currently in draft status because the test suite is missing. Test suite is done as far as I can tell.

@majewsky majewsky requested a review from VoigtS October 16, 2023 13:40
@coveralls
Copy link

coveralls commented Oct 16, 2023 •
edited
Loading

Coverage Status

coverage: 80.665% (+0.6%) from 80.108% when pulling 23a5712 on commitments into e46d82b on master.

@majewsky
add DB model for commitments
2351a4d
@majewsky
add basic API for commitments
037ac0f 
Test coverage will follow in the next commit(s).
@majewsky majewsky marked this pull request as ready for review October 16, 2023 20:51
@majewsky
Copy link
Contributor Author

I reviewed this with @VoigtS in person and got verbal approval.

@majewsky majewsky merged commit f2220fb into master Oct 17, 2023
6 checks passed
@majewsky majewsky deleted the commitments branch October 17, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majewsky @coveralls