feat: add support for user-installable apps #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
SerenModz21
requested review from
favna,
kyranet and
vladfrangu
as code owners
vladfrangu
previously approved these changes
Sep 5, 2024
vladfrangu
approved these changes
Sep 6, 2024
favna
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
discord.js,@discordjs/builders, and@sapphire/discord-utilitiesThe reason for the type assertions for the contexts and integration types is that
discord.jswants a read-only array, whilediscord-api-typesdoesn't.For the group DM typing issue, I hope the type guards that I have added are a sufficient fix.
And finally, I think I've put the
use external appspermission in the correct place - to match the ordering.