Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to check directory structure #36

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

manabuishii
Copy link
Collaborator

Currently sapporo run directory structureis

2chars_of_run_id/run_id/...

So we need check run_request.json in this kind of path.

suecharo and others added 4 commits February 4, 2024 18:49
Currently sapporo run directory structureis

2chars_of_run_id/run_id/...

So we need check run_request.json in this kind of path.
@manabuishii
Copy link
Collaborator Author

Potentially if some put the file name is run_request.json as their files.
I think sapporo miscount uploaded file ?

@suecharo
Copy link
Collaborator

suecharo commented Mar 4, 2024

@manabuishii

Indeed, you are right.
If use "**/{RUN_DIR_STRUCTURE['run_request']}", it would also look into dir like the exe_dir, which would degrade performance.
Additionally, if there's another file named run_request.json, it would unintentionally be counted as a run.

I think it's ok to proceed with the merge.

@suecharo suecharo changed the base branch from main to develop March 4, 2024 10:23
@suecharo suecharo merged commit fea9f41 into develop Mar 4, 2024
4 checks passed
@suecharo suecharo deleted the faster_directory_check branch March 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants