Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start/resume channels array error on OSX #2

Open
natalieda opened this issue Apr 29, 2020 · 3 comments
Open

start/resume channels array error on OSX #2

natalieda opened this issue Apr 29, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@natalieda
Copy link
Collaborator

When I start/resume a channel on my mac with ada I get this error:

The channel starts successfully: ./ada: line 892: declare: -A: invalid option declare: usage: declare [-afFirtx] [-p] [name[=value] ...]

What are the options to bypass the error on OSX?

@onnozweers
Copy link
Contributor

onnozweers commented May 8, 2020

Hi Natalie,

OSX has bash version 3, which is pretty outdated and does not support associative arrays (defined by declare -A). This is discussed here: https://stackoverflow.com/questions/6047648/bash-4-associative-arrays-error-declare-a-invalid-option

We have a few options:

  • There's brew install bash but then we'd need to change the shebang #!/bin/bash to #!/usr/bin/env bash. In https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash I can find no reason not to do that. We could then build in a check whether the actual bash version is sufficient for the task we're doing.
  • Use a workaround that doesn't need associative arrays. There is one in the first mentioned StackOverflow discussion.
  • We don't support SSE events on OSX.

@onnozweers onnozweers self-assigned this May 8, 2020
@natalieda
Copy link
Collaborator Author

Hi Onno,

Thank you for investigating the options. I would go for the first option to ensure portability of ada in all systems including the events operations if this is technically possible. In any case we will advice users to start channels on a host machine that is continuously running (i.e. a linux server such as our UIs) and not their laptops to avoid loosing events when the machine is offline.

@onnozweers
Copy link
Contributor

Fixed in f1fa4e8

@onnozweers onnozweers added the enhancement New feature or request label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants