Feature/jc 702 initialize anime app #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TebyakinaEkaterina
requested review from
a team,
shalomich,
irina-baleevskih-saritasa,
maxineo and
artem-sotnichenko-saritasa
and removed request for
a team
shalomich
approved these changes
Aug 16, 2024
apps/react/src/features/genres/components/GenresFilterForm/GenresFilterForm.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresList/GenresList.module.css
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresList/GenresList.tsx
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenreCard/GenreCard.tsx
Outdated
Show resolved
Hide resolved
|
@TebyakinaEkaterina Please give your commits more specific names. I do not recommend calling them "Refactoring code", because sometimes it is necessary to go back through the commit history, for example, to find when a bug appeared, and such commit messages do not help in any way |
artem-sotnichenko-saritasa
requested changes
Aug 16, 2024
apps/react/src/features/genres/components/GenresList/GenresList.module.css
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresList/GenresList.module.css
Outdated
Show resolved
Hide resolved
apps/react/src/features/genres/components/GenresList/GenresList.tsx
Outdated
Show resolved
Hide resolved
|
artem-sotnichenko-saritasa
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement base layout for React solution.