Fix reportPrivateImportUsage for VS Code
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M1troll
requested review from
ron8mcr,
TheSuperiorStanislav and
NikAzanov
as code owners
M1troll
changed the title
reportPrivateImportUsage\ for VS CodereportPrivateImportUsage for VS Code
TheSuperiorStanislav
approved these changes
Nov 14, 2023
ron8mcr
requested changes
Nov 14, 2023
M1troll
force-pushed
the
feature/fix-private-import-error
branch
from
529d6d7
to
78d2177
Compare
ron8mcr
approved these changes
Nov 15, 2023
In VS Code `Pylance` when trying to import non-module names from `pomcorn` raises `reportPrivateImportUsage`.
M1troll
force-pushed
the
feature/fix-private-import-error
branch
from
78d2177
to
f1ff858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VS Code
Pylancewhen trying to import non-module names frompomcornraises reportPrivateImportUsage.This doesn't interfere with the package, and
mypydoesn't swear at it, but we lose the import hints described in the main __init__.py fileand see the nasty underline:
I found the following two solutions:
__all__symbol as written in the pyright docsimport pomcorn.locators.xpath_locators as locators)I find it very convenient to use a short import, so I implemented the first solution.