Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reportPrivateImportUsage for VS Code #5

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix reportPrivateImportUsage for VS Code #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 18 additions & 4 deletions pomcorn/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
from .component import Component, ComponentWithBaseLocator, ListComponent
from .element import Element, XPathElement
from .page import Page
from .web_view import WebView
from pomcorn.component import (
Component,
ComponentWithBaseLocator,
ListComponent,
)
from pomcorn.element import Element, XPathElement
from pomcorn.page import Page
from pomcorn.web_view import WebView

__all__ = (
"Component",
"ComponentWithBaseLocator",
"ListComponent",
"Element",
"XPathElement",
"Page",
"WebView",
)
26 changes: 24 additions & 2 deletions pomcorn/locators/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
from .base_locators import Locator, TInitLocator, TLocator, XPathLocator
from .xpath_locators import (
from pomcorn.locators.base_locators import (
Locator,
TInitLocator,
TLocator,
XPathLocator,
)
from pomcorn.locators.xpath_locators import (
ButtonWithTextLocator,
ClassLocator,
DataTestIdLocator,
Expand All @@ -11,3 +16,20 @@
TagNameLocator,
TextAreaByLabelLocator,
)

__all__ = (
"Locator",
ron8mcr marked this conversation as resolved.
Show resolved Hide resolved
"TInitLocator",
"TLocator",
"XPathLocator",
"ButtonWithTextLocator",
"ClassLocator",
"DataTestIdLocator",
"ElementWithTextLocator",
"IdLocator",
"InputByLabelLocator",
"NameLocator",
"PropertyLocator",
"TagNameLocator",
"TextAreaByLabelLocator",
)
9 changes: 5 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ python = ">= 3.11, < 4.0"
# Python bindings for Selenium
# https://selenium-python.readthedocs.io/index.html
selenium = ">= 4.12"
# Fixed version until fix of https://github.com/jorisroovers/gitlint/issues/535
virtualenv = "20.24.5"

[tool.poetry.group.dev.dependencies]
# Improved REPL
Expand All @@ -53,6 +51,8 @@ ipython = ">= 8.14.0"
# A framework for managing and maintaining multi-language pre-commit hooks.
# https://pre-commit.com/
pre-commit = ">= 3.3.3"
# Fixed version until fix of https://github.com/jorisroovers/gitlint/issues/535
virtualenv = "20.24.5"
# Collection of invoke commands
# https://github.com/saritasa-nest/saritasa-python-invocations
saritasa-invocations = ">= 0.8"
Expand Down Expand Up @@ -113,17 +113,18 @@ known_pytest=[
"_pytest",
"xdist",
]
known_page_object="page_object"
sections=[
"FUTURE",
"STDLIB",
"THIRDPARTY",
"PYTEST",
"PAGE_OBJECT",
"FIRSTPARTY",
"LOCALFOLDER",
]
include_trailing_comma=true
# For sorting `__all__` sections
# Off until the issue is fixed: https://github.com/PyCQA/isort/issues/2193
# sort_reexports=true

[tool.flake8]
# F403: using wildcard imports (from … import *)
Expand Down