Feature/sn 733 use calculated properties inside navigation #86
+61
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMakarov124
requested review from
vasiliy-chefonov,
toanphamsaritasa,
tanhieu-nguyen and
mchernikov80
as code owners
vasiliy-chefonov
approved these changes
Oct 1, 2024
| @@ -65,6 +65,12 @@ public void Configure(EntityOptionsBuilder<Shop> entityOptionsBuilder) | |||
| .SetIsSortable(true) | |||
| .SetSearchType(SearchType.ContainsCaseInsensitive); | |||
| }) | |||
| .IncludeProperty(address => address.FullAddress, builder => | |||
| { | |||
| builder | |||
There was a problem hiding this comment.
Can it be sortable?
| @@ -65,6 +65,12 @@ public void Configure(EntityOptionsBuilder<Shop> entityOptionsBuilder) | |||
| .SetIsSortable(true) | |||
| .SetSearchType(SearchType.ContainsCaseInsensitive); | |||
| }) | |||
| .IncludeProperty(address => address.FullAddress, builder => | |||
There was a problem hiding this comment.
I'm not sure if we can apply the same Fluent API for the calculated properties. Some of the builder methods are useless for them, like SetIsExcludedFromQuery or smth. In the future, we can have even more.
toanphamsaritasa
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SN-733
Changed logic of getting calculated properties metadata, now it similar to ordinary properties, so a user can configure it just the same as usual property. Also, they will be displayed by default and can be added as part of a navigation.