Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: media manager, error response schema parsings and other minor fixes #28

Merged
merged 20 commits into from
May 29, 2024
Merged

fix: media manager, error response schema parsings and other minor fixes #28

merged 20 commits into from
May 29, 2024

Conversation

sarthakjdev
Copy link
Owner

@sarthakjdev sarthakjdev commented May 16, 2024 •
edited
Loading

Issue #26

  • We have removed support for phone number manager as of now, the reason is that this library is intended to be a single client library linked linked with a single phone number. So if a client is already initiated with a phone number, this would be fundamentally wrong to use to verify its sibling, instead this would have been a parent client without phone number dependency -> verifying phone number and selection. We can do that, the code is written dynamically. But for the sake of simplicity, we will keep it this way, only and if somebody wants to add a phone number they still have to use the meta business platform, for which guides will be added soon to /guide of website.
  • Support added for getUrl and delete media.
  • Proper error handling and response schema for the send and other functions used.
  • Fixes ESM support bug

@sarthakjdev
fix: return typings generics for requestCloudApi Method and other man…
a11c750 
…ager methods

Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
chore: wip
281ae99 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
chore: wip
c3b03fa 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
Merge branch 'master' of github.com:sarthakjdev/wapi.js into fix/mana…
1b5b7b7 
…gers

Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev sarthakjdev self-assigned this May 27, 2024
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@github-actions GitHub Actions
Copy link

🟢 Deployment success:

Deployed Url: https://wapijs-4pxa9kcwb-sarthak-jains-projects-940d0d6f.vercel.app

@sarthakjdev
fix: build
0f2be4f 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
chore: remove phone number manager
b64df41 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev sarthakjdev changed the title fix: return typings generics and managers implementation fix: managers implementation May 27, 2024
@sarthakjdev sarthakjdev changed the title fix: managers implementation fix: managers May 27, 2024
@sarthakjdev
chore: Wip
fd07f52 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
chore: remove upload media handler for now, no need of it just adding…
a35d2ad 
… complexity to the lib as of now, will add if somebody needs it.

Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: linter
b43fd2c 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev sarthakjdev changed the title fix: managers fix: media manager, error response schema parsings and esm support bug May 29, 2024
@sarthakjdev sarthakjdev mentioned this pull request May 29, 2024
Closed
@sarthakjdev
fix: minor changes
4aab334 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: lint
4ccadb6 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
fix: lint
48fca50 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: webhook should not be extending the evenet emitter
dbe290d 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: webhook should not be extending the evenet emitter
0849d29 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: linter
029f993 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: linter
2311f56 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@github-actions GitHub Actions
Copy link

🚨 Linter failed

@sarthakjdev
fix: linter
236f515 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
fix: linter
94d6871 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
fix: linter
1df9f76 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev
fix: concurrency check
46c2725 
Signed-off-by: sarthakjdev <jsarthak448@gmail.com>
@sarthakjdev sarthakjdev marked this pull request as ready for review May 29, 2024 18:16
sarthakjdev
sarthakjdev commented May 29, 2024
View reviewed changes
Copy link
Owner Author

@sarthakjdev sarthakjdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS OK!

@sarthakjdev sarthakjdev changed the title fix: media manager, error response schema parsings and esm support bug fix: media manager, error response schema parsings and other minor fixes May 29, 2024
@sarthakjdev sarthakjdev merged commit 6feec43 into master May 29, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
chore(release): 0.1.1 [skip ci]
2b11b25 
# [create-wapi-app-v0.1.1](create-wapi-app-v0.1.0...create-wapi-app-v0.1.1) (2024-05-29)

### Bug Fixes

* media manager, error response schema parsings and other minor fixes  ([#28](#28)) ([6feec43](6feec43))
@sarthakjdev
Copy link
Owner Author

🎉 This PR is included in version create-wapi-app-v0.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
chore(release): 0.0.8 [skip ci]
0f50da7 
# [@wapijs/wapi.js-v0.0.8](https://github.com/sarthakjdev/wapi.js/compare/@wapijs/wapi.js-v0.0.7...@wapijs/wapi.js-v0.0.8) (2024-05-29)

### Bug Fixes

* media manager, error response schema parsings and other minor fixes  ([#28](#28)) ([6feec43](6feec43))
@sarthakjdev
Copy link
Owner Author

🎉 This PR is included in version @wapijs/wapi.js-v0.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sarthakjdev sarthakjdev

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarthakjdev