Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (PSKD-792) Update default version of cert-manager to v1.16.2 #585

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Dec 10, 2024

Changes

  • Update default version of cert-manager installed to v1.16.2
  • Replaced deprecated installCRDs Helm option value with supported option

Tests

Scenario Provider K8S version DAC method Installed CERT-MANAGER_CHART_VERSION CERT_MANAGER_CHART_VERSION order cadence Notes
1 Azure 1.29 docker 1.14.4 1.16.2 n/a n/a Running DaC with the default version of 1.16.2 and "baseline,install" results in a successful cert-manager upgrade to version v1.16.2
2 AWS 1.30 docker None 1.16.2 * n/a Resulting error message. installCRDs value is the incorrect type, it should be true, not "true". That value is deprecated for v1.16.2 so removing and replacing it with crds.enabled option per cert-manager values.yaml file.
3 AWS 1.30 docker None 1.16.2 * n/a Altered the value for installCRDs to a boolean from string, Result: version 1.16.2 was successfully installed with this warning message stating that the installCRDs Helm option is deprecated. Updating the configuration to use crds.enabled options instead, retest install with change for Scenario 4:
4 AWS 1.30 local None 1.16.2 * n/a Successful v1.16.2 install. Updated the configuration to use crds.enabled Helm options as below instead of installCRDs which has been deprecated
5 Azure 1.29 docker None 1.16.2 * 2024.11 With updated configuration to use crds.enabled Helm options cert-manager v1.16.2 installed successfully. Successful deployment of stable:2024.11 cadence. Successful login to Viya application and navigation to SAS Studio which created a compute context.

Signed-off-by: David.Houck <David.Houck@sas.com>
Signed-off-by: David.Houck <David.Houck@sas.com>
@dhoucgitter dhoucgitter added the enhancement New feature or request label Dec 10, 2024
@dhoucgitter dhoucgitter self-assigned this Dec 10, 2024
@dhoucgitter dhoucgitter merged commit 4615bf9 into staging Dec 12, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the PSKD-792 branch December 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants